-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/#866 matchmaker timeout #867
Issue/#866 matchmaker timeout #867
Conversation
Codecov Report
|
606d75b
to
3e5f28d
Compare
Game_id works |
self.session = int(random.randrange(0, 4294967295)) | ||
self.protocol: Protocol = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like which way typing is going! 👍
@@ -303,7 +303,7 @@ async def test_game_matchmaking_disconnect(lobby_server): | |||
|
|||
msg = await read_until_command(proto2, "match_cancelled", timeout=120) | |||
|
|||
assert msg == {"command": "match_cancelled"} | |||
assert msg == {"command": "match_cancelled", "game_id": 41956} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this id set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be 1 higher than the highest game id in the test data.
game_id
tomatch_cancelled
message so the client can choose to ignore it if the message doesn't apply to the current gamestart_game
from stalling on hung connections. The timeouts should always be followed now.@Sheikah any preference on what to call the
game_id
field? I thinkgame_id
makes sense but ingame_info
it's calleduid
.Mitigates some of #866 but doesn't fix it completely.